[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] COMMENT_IF_NO_POD2MAN broken?
From: |
Giuseppe Scrivano |
Subject: |
Re: [Bug-wget] COMMENT_IF_NO_POD2MAN broken? |
Date: |
Tue, 28 Oct 2014 10:35:56 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Tim Ruehsen <address@hidden> writes:
> On Monday 27 October 2014 11:23:45 Dan McDonald wrote:
>> Hello from OmniOS (an illumos distro). Giuseppe told me to send this report
>> here.
>>
>> Consider this diff:
>>
>>
>> http://git.savannah.gnu.org/cgit/wget.git/commit/doc/Makefile.am?id=d1ab00c
>> ab4d644d1048ed279f90e633b82cf4455
>
> Thanks for your report, Dan.
>
> @Giuseppe, I don't understand this commit.
> It just doesn't do what (I guess) you expect it to do.
>
> Look at the (generated) doc/Makefile:
> ...
> # Version: $(VERSION)
> ...
>
> I would expect the (numeric) Wget version a that place.
> But that needs a @VERSION@ in doc/Makefile.am and not $(VERSION).
>
> Since you also replaced some other variables - maybe all these changes are
> wrong ???
>
> Could you please have a look at it ?
I am going to revert it and push the patch.
Thanks,
Giuseppe