Re: [Bug-wget] [PATCH] Small fix for limited number of strings (and potential garbage value) in arguments to concat_strings

[Tim Ruehsen]

On Monday 27 October 2014 23:57:00 Pär Karlsson wrote:
> No complaints from me, it applied cleanly, all tests OK. :-)
> 
> 2014-10-27 21:53 GMT+01:00 Tim Rühsen <address@hidden>:
> > Am Samstag, 25. Oktober 2014, 11:09:48 schrieb Pär Karlsson:
> > > Good point. I got carried away by the criticism against xrealloc being
> > 
> > too
> > 
> > > expensive, etc, but you are of course right. Your implementation seems
> > > to
> > > me the most readable, and in this context, it's what matters. :-)
> > > 
> > > Thanks for the tip re: callgrind :-)
> > > 
> > > /Pär
> > > 
> > > 2014-10-24 20:39 GMT+02:00 Tim Rühsen <address@hidden>:
> > > > Pär, thanks for your work.
> > > > 
> > > > *BUT* speed does not really matter here. My intention was to show code
> > > > that is
> > > > much more readable than the current implementation which is
> > > > unnecessary
> > > > complicated and not even understandable by the LLVM/clang analyzer.
> > > > That piece of code should be replaced.
> > > > 
> > > > FYI, if you want to work on CPU cycle optimization, use valgrind --
> > > > tool=callgrind for your wget command to be polished. The resulting
> > > > file
> > > > can be
> > > > viewed with e.g. kcachegrind.
> > > > 
> > > > Tim
> > 
> > i made up a patch.
> > 
> > Any complaints ?
> > 
> > Tim

Pushed.

Tim

signature.asc
Description: This is a digitally signed message part.