[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] Issue with --content-on-error and --convert-links

From: Tim Ruehsen
Subject: Re: [Bug-wget] Issue with --content-on-error and --convert-links
Date: Thu, 29 Jan 2015 14:26:20 +0100
User-agent: KMail/4.14.2 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )

Hi Yousong,

> > this patch seems to be incomplete. Do you have a complete patch (e.g. +new
> > option, + docs) or are you going to work on it ?
> That patch was only intended as a ephemeral one to see if it can solve
> the issue reported by Joe at the time.  But checking it again, I now
> think the patch actually does the right thing.  The reason is that
> since those --content-on-error pages are downloaded, then links within
> those pages should be converted as specified by --convert-links.
> There is no need for a new option for this and the current doc is just
> fine.  But I will try adding an test cases for this.

Ah sorry, my fault / misunderstanding.
Since the patch changes Wget behaviour I would apply it after the next bugfix 
A test case would be perfect. Please consider creating a python test case (see 
directory testenv). We will move all test cases from perl to python by the 


Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]