[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-wget] [PATCH] rejected-log: Add option to dump URL rejections t

From: Giuseppe Scrivano
Subject: Re: [Bug-wget] [PATCH] rejected-log: Add option to dump URL rejections to a log.
Date: Mon, 27 Jul 2015 17:03:53 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Jookia <address@hidden> writes:

> This allows you to figure out why URLs are being rejected and some context
> around it.
> ---
>  doc/wget.texi |   5 ++
>  src/init.c    |   2 +
>  src/main.c    |   3 ++
>  src/options.h |   2 +
>  src/recur.c   | 149 
> ++++++++++++++++++++++++++++++++++++++++++++++++----------
>  5 files changed, 135 insertions(+), 26 deletions(-)

I tried the patch but some tests fail after I apply it, could you verify
that "make check" passes without problems?  It seems wget exits with the
wrong return code.

In addition, could you add a ChangeLog-like format for the commit
message?  You can check recent commits to see how the style looks like.

Would be nice to have a test for the new option.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]