[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [PATCH] Patch to change behavior with redirects under --r
From: |
Dale R. Worley |
Subject: |
Re: [Bug-wget] [PATCH] Patch to change behavior with redirects under --recurse. |
Date: |
Fri, 07 Oct 2016 10:38:56 -0400 |
Tim Ruehsen <address@hidden> writes:
> the changes in recur.c are not acceptable. They circumvent too many checks
> like host-spanning, excludes and even --https-only.
>
> Maybe leaving descend_redirect() and checking the returned reject reason
> could
> solve your issue. I'll have a closer look at it soon.
Looking at the files I have saved, I certainly made a mistake in
"0004-Patch-to-change-behavior-with-redirects-under-recurs.patch". This
section was for testing purposes and I should not have sent it:
diff --git a/src/recur.c b/src/recur.c
index 2b17e72..fe0d012 100644
--- a/src/recur.c
+++ b/src/recur.c
@@ -360,6 +360,7 @@ retrieve_tree (struct url *start_url_parsed, struct iri *pi)
{
reject_reason r = descend_redirect (redirected,
url_parsed,
depth, start_url_parsed, blacklist, i);
+ r = WG_RR_SUCCESS;
if (r == WG_RR_SUCCESS)
{
/* Make sure that the old pre-redirect form gets
Dale