Re: [Bug-wget] [bug #48811] netrc password wins over interactive --ask-password

[Wajda, Piotr]

Hi All,
I've sent patch for this before already, but it hasn't been reviewed 
yet. Besides logic correction, I've rebuilt/cleaned up code a bit.

Piotr

On 20/12/16 00:12, Vijeth Aradhya wrote:
> Follow-up Comment #2, bug #48811 (project wget):
>
> Hi Basin,
>
> I'm new to the wget community, but I have looked through the program logic for
> ftp and http password and realized it is wrong.
>
> BEFORE changes
>
> Initially, search_netrc function was called first, and if it existed, the
> password was assigned to passwd, and used in the next logic step ( this is
> WRONG because if the user entered the password with --ask-password, then that
> should be given priority ).
>
> passwd = passwd ? passwd : ......
>
> AFTER changes
>
> I have changed the logic such that it first sees if there is an --ask-password
> passwd stored, and if it is not there, then it uses the netrc password.
>
> I have attached the corresponding patch file to this. Please have a look :-)
>
> This would be my first contribution to wget (GNU) as well and so eagerly
> waiting for the code review!
>
> (file #39280)
>     _______________________________________________________
>
> Additional Item Attachment:
>
> File name:
> 0001-Corrected-the-logic-for-ftp-and-http-password-usage-auth_varadhya.patch
> Size:2 KB
>
>
>     _______________________________________________________
>
> Reply to this item at:
>
>   <http://savannah.gnu.org/bugs/?48811>
>
> _______________________________________________
>   Message sent via/by Savannah
>   http://savannah.gnu.org/