[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-wget] [bug #48811] netrc password wins over interactive --ask-p
Re: [Bug-wget] [bug #48811] netrc password wins over interactive --ask-password
Tue, 20 Dec 2016 08:21:01 +0100
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1
I've sent patch for this before already, but it hasn't been reviewed
yet. Besides logic correction, I've rebuilt/cleaned up code a bit.
On 20/12/16 00:12, Vijeth Aradhya wrote:
Follow-up Comment #2, bug #48811 (project wget):
I'm new to the wget community, but I have looked through the program logic for
ftp and http password and realized it is wrong.
Initially, search_netrc function was called first, and if it existed, the
password was assigned to passwd, and used in the next logic step ( this is
WRONG because if the user entered the password with --ask-password, then that
should be given priority ).
passwd = passwd ? passwd : ......
I have changed the logic such that it first sees if there is an --ask-password
passwd stored, and if it is not there, then it uses the netrc password.
I have attached the corresponding patch file to this. Please have a look :-)
This would be my first contribution to wget (GNU) as well and so eagerly
waiting for the code review!
Additional Item Attachment:
Reply to this item at:
Message sent via/by Savannah