Re: [Bug-wget] wget -mk behavior changed from 16 to 18 for JavaScript files (Addendum2, now consistent)

[Angelo Fuchs]

To make it consistently fail in 18, but not in 16:

When downloading the url for the second time it always fails.

I also made it simpler to test:

wget -mk http://steamnet.de/wget_broken_in_18/
wget -mk http://steamnet.de/wget_broken_in_18/

will produce a file "js/script.js" that looks like this:

> someFunc=function(C){L=J('<a href="script.js#"></a>')};

but it should look like this:

> someFunc=function(C){L=J('<a href="#"></a>')};

Now that I have it consistently I will report a bug on the bugtracker.

Have a nice day

Angelo

Am Tue, 14 Nov 2017 13:36:41 +0100
schrieb Angelo Fuchs <address@hidden>:

> Addendum:
> 
> I still can't make it fail every time. The issue appears more often
> when "-mkK" is specified then when only "-mk" is.
> 
> I'll try to make it appear more consistently and also easier to test.
> (currently you have to search for "href" in the downloaded script.js
> and see if the links is "#" or "script.js#" (the first being correct,
> the second wrong).
> 
> Am Tue, 14 Nov 2017 13:30:36 +0100
> schrieb Angelo Fuchs <address@hidden>:
> 
> > Hi Tim,
> > 
> > sorry for the double mail, didn't look on the Heads.
> > 
> > I assume it has something to do with the way the js files are
> > linked. See this example:
> > 
> > wget -mk http://steamnet.de/wget_js_reproducer/
> > 
> > This will download 3 files. Two html files one javascript.
> > Expected (and performed by V16) would be that the HTML has its links
> > converted, but the JS being unmodified.
> > 
> > Happening (in V18) is that all 3 files get their "links" modified
> > (which is wrong in the JS file, it should not have its links
> > modified, they are dynamic code that gets inserted into html files
> > afterwards).
> > 
> > If you copy the result of version 16, remove the index2 site and
> > version 18 will work correctly (and thus inconsistent).
> > 
> > There is also this issue:
> > wget -mkK does not create a .orig file for the Javascript file in
> > the example, even though the file has been changed, it is also NOT
> > REPORTED as being changed. This made it impossible to fix this issue
> > just by overriding the changed .js file with the .orig file. When JS
> > files are replaced by Version 16 (which happens if you only have
> > index2 of the example present) the .orig files are generated.
> > 
> > I hope this helps.
> > 
> > Bye Angelo
> > 
> > 
> > Am Wed, 08 Nov 2017 21:39:47 +0100
> > schrieb Tim Rühsen <address@hidden>:
> >   
> > > On Mittwoch, 8. November 2017 10:38:47 CET Angelo Fuchs wrote:    
> > > > Hi,
> > > >       
> > > 
> > > Hi Angelo,
> > >     
> > > > I'm using wget to make a static mirror of a wordpress instance.
> > > > When I updated to version 18 the process broke because now
> > > > strings in javascript files that look like html links are
> > > > converted by -k.      
> > > 
> > > Can't remember any related change in the last years.
> > >     
> > > > Before I go into too much detail and write instructions on how
> > > > to reproduce this, I would like to know if this bug is already
> > > > known.
> > > > 
> > > > I tried finding a bugtracker, but didn't succeed.      
> > > 
> > > Please have a look at
> > > https://savannah.gnu.org/bugs/?group=wget
> > > 
> > > A small reproducer would be great.
> > > 
> > > Regards, Tim    
> > 
> > 
> > ... - . .- -- -. . -
> > SteamNet GbR
> > IT-Beratung • Programmierung • Design
> > Entwickler • Joomla • Wordpress • CMS
> > 
> > Glottertalstraße 7
> > D - 79271 St. Peter
> > 
> > Telefon: +49 (7660) 9414913
> > Mobil: +49 (163) 4808557
> > 
> > E-Mail:address@hidden
> > Web:www.steamnet.de  
> 
> 
> ... - . .- -- -. . -
> SteamNet GbR
> IT-Beratung • Programmierung • Design
> Entwickler • Joomla • Wordpress • CMS
> 
> Glottertalstraße 7
> D - 79271 St. Peter
> 
> Telefon: +49 (7660) 9414913
> Mobil: +49 (163) 4808557
> 
> E-Mail:address@hidden
> Web:www.steamnet.de


... - . .- -- -. . -
SteamNet GbR
IT-Beratung • Programmierung • Design
Entwickler • Joomla • Wordpress • CMS

Glottertalstraße 7
D - 79271 St. Peter

Telefon: +49 (7660) 9414913
Mobil: +49 (163) 4808557

E-Mail:address@hidden
Web:www.steamnet.de

pgpBpkf5dLFMP.pgp
Description: Digitale Signatur von OpenPGP