Re: [Bug-wget] [PATCH] Fixes for issues found by Coverity static analysis

[Darshit Shah]

Hi Tomas,

Thanks for running the scan and the patches you've made! I briefly glanced
through those and they seem fine. Of course, they will need to be slightly
modified to apply to the current git HEAD. I can do that in the coming days and
apply these patches.

I would like to ask you if there is a regular scan of Wget that you have set up
on Coverity. We used to run coverity scans regularly, but since the last year
or so, I haven't managed to get the coverity binaries to execute on my system.
So the scans stopped. If you have a scheduled run, I would like to be able to
see the results on Coverity so that we can keep fixing those issues.

P.S.: It seems like you haven't assigned your copyrights to the FSF for Wget.
Do you happen to know if your employer has assigned the copyrights on your
behalf? I couldn't find any mentions in the list I have locally. You will
shortly receive the assignment form in a separate email.

* Tomas Hozza <address@hidden> [180825 02:21]:
> Hi.
> 
> We scanned the latest version of wget (1.19.5) with Coverity static analyzer. 
> It found some potentially important issues like RESOURCE LEAKS. I'm attaching 
> my proposed fixes for these issues. Each commit includes the output from 
> Coverity and the outcome of my analysis of the problem from sources.
> 
> Regards,
> Tomas
> -- 
> Tomas Hozza
> Associate Manager, Software Engineering - EMEA ENG Core Services
> 
> PGP: 1D9F3C2D
> UTC+1 (CET)
> Red Hat Inc.                 http://cz.redhat.com


-- 
Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6

signature.asc
Description: PGP signature