Re: [Bug-XBoard] Problem with seek graph

[h . g . muller]

Op Wo, 7 maart, 2012 11:07 pm schreef Byrial Jensen:
> I had a problem with using the seek graph while playing on FICS.

Hmm, so there seems to be a race condition somewhere. Perhaps we should
still fix this before releasing 4.6.0. The seek graph is drawn on the
prompt when there is a 'sought pending', because on ICC and the
open-source ICS there is no explicit termination of the seek-ad list. (On
FICS there is a line giving the number.). But I guess it should not do
that if the prompt is sent after another command, which sneaked in between
sending the sought and getting the list in reply. I could just clear the
'sought-pending' condition case a game is started. There could be other
unsolicited output as well, however. (shouts, tells)

I guess a prompt arriving when the list of collected seek-ads is still
empty should be ignored. I hope ICS would never break up the seek-ad list
with another command. So once you see a seek-ad line, you can be sure that
the following prompt will terminate it. This means the graph would never
be drawn if there are no seek ads, which is just as well.

It is also not very robust that there are conditions under which you
cannot pop down a seek graph with a left-click. This must be because of
testing in the wrong order: first for the gameMode, and if it is not idle,
assuming that the seek graph cannot be up. It should test on left-click if
the graph is up first, and take it down automatically if a later test on
the gameMode reveals that it is not supposed to be, and only take the
click seriously (e.g. test if it is on a dot) when in idle mode.

I will fix this first thing in the morning.