bug-xboard
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-XBoard] xboard/parser.c:s/inline/& static/g


From: david a. delagarza
Subject: [Bug-XBoard] xboard/parser.c:s/inline/& static/g
Date: Mon, 14 Jul 2014 09:39:23 +0000

Hello,


I had been looking for a Linux version of Chu Shogi for over 3 years now, and I'm finally able to play thanks to XBoard+HaChu!  Thank you so very much!

First, where are the (dev) sources for hachu officially located?  I found a version here, but I couldn't find a git clone url so I had to cURL each of the 83 files by hand (but it was totally worth it!).  Is the url missing from the page or did I just overlook it?

Next, in xboard/parser.c:
`inline int` should be `inline static int`
for this (line 90):
inline int
Match (char *pattern, char **ptr)
and also for this (line 102):
inline int
Word (char *pattern, char **p)
because the C99 specification requires that inline-but-not-static functions must have a non-inline'd version in the event that the compiler was unable to inline them -- `inline` is only a "hint" to the compiler.  Please see this SO question for more information.  I was able to link with CC=clang only after I did s/inline/& static/g to fix it.

Finally, if it's alright with you, I'd love to contribute to the development of xboard by fixing any code that causes trivial compiler/linker warnings (many such warnings are due to things as easily fixed as a missing typecast or parens).  I'm really good at that sort of thing (As a professional C programmer, I regularly compile with `-std=c99 -O3 -Wall -Wextra -Werror -pedantic-errors` on each of gcc and clang and I never have to use any -Wno-whatever flags for my code to build).  If it's okay for me to help out like this, then could you please tell me which repository to fork and create pull requests for?  There are multiple repos and ftp servers and the like for xboard and winboard and I'm not sure which is the official development head.


Thank you again so very much for a Chu Shogi implementation on Linux!!!!

david a.
>^,^<


reply via email to

[Prev in Thread] Current Thread [Next in Thread]