Re: [Bug-XBoard] xboard/parser.c:s/inline/& static/g

[h . g . muller]

Op Ma, 14 juli, 2014 11:39 am schreef david a. delagarza:

> First, where are the (dev) sources for hachu *officially* located?  I
> found a version here ...

Yes, hgm.nubati.net/cgi-bin/gitweb.cgi is where my primary source
repositories are.

> but I couldn't find a git
> clone url so I had to cURL each of the 83 files by hand (but it was
> totally worth it!).  Is the url missing from the page or did I just
> overlook it?

 I am not sure why gitweb does not show a clone link (it certainly knows
to find the directory itself...). The link would be

http://hgm.nubati.net/git/hachu.git (or xboard.git or fairymax.git etc.).

Note that the hachu repository only has a 'public' branch.

>
> Next, in xboard/parser.c:
> `*inline int*` should be `*inline static int*`
> for this (line 90):
>
>> inline int Match (char *pattern, char **ptr)
>>
>
> and also for this (line 102):
>
>> inline int Word (char *pattern, char **p)
>>
>

OK, thanks. It already puzzled me why some platforms produced
undefined-reference linker errors for those routines!

>
> Finally, if it's alright with you, I'd love to contribute to the
> development of xboard by fixing any code that causes trivial
> compiler/linker warnings

Well, any help is welcome, but you should realize that some of the
warnings could be intentional, because I disagree with the compiler about
what is desirable / error prone. So in particular we always compile with
-Wno-parentheses, because I prefer to work with easily readable code,
while the compiler would insist on unreadable error-prone code poisoned
with redundent parentheses.

> If it's
> okay for me to help out like this, then could you please tell me which
> repository to fork and create pull requests for?  There are multiple
> repos and ftp servers and the like for xboard and winboard and I'm not
> sure which is the official development head.

The official source repository is that at
http://savannah.gnu.org/projects/xboard . But the hgm.nubati.net
repository is slightly more 'upstream', and can be ahead in development.
The master branch there should really be considered a fork, which later
will be merged into the master branch at Savannah, and before doing that I
usually rebase it interactively onto anything that might have been added
by others to the Savannah master, and to reduce the number of commits.

At the moment hgm.nubati.net is ahead of Savannah by an unusually large
amount, because in the process of patching it with new features I broke
some stuff in the ICS mode of the Xaw build that we'd rather not merge
into Savannah, as I am rather busy now, and there is no way predicting
when I will have time to fix those. (But in the mean time I do put quick
fixes of other problems that emerge there...) It also contains some
patches relevant to Chu Shogi, though, so if you are specifically
interested in Chu that repository would give you the best version.

>
>
> Thank you again *so* very much for a Chu Shogi implementation on
> Linux!!!!
>

You're welcome! It is a great game, and I hope that availability in XBoard
will help to make it more widely known.

H.G.