Re: xorriso 1.5.6 build issue

[Thomas Schmitt]

Hi,

Rui Chen wrote:
> It looks like xorriso 1.5.6 has some build issue as shown below:
>  ./libisofs/rockridge.h:206:1: error: unknown type name 'ssize_t'; did you 
> mean 'size_t'?
>  ssize_t rrip_calc_len(Ecma119Image *t, Ecma119Node *n, int type, size_t 
>space,

Hrmpf. A bug even before the announcements are out.
(It works fine on my GNU/Linux system.)

Thanks for reporting.


> This is the build patch
> --- a/libisofs/rockridge.h
> +++ b/libisofs/rockridge.h
> +/* For ssize_t */
> +#include <unistd.h>

Does <sys/types.h> do the trick for you, too ?

I asked Google where ssize_t is supposed to be defined on GNU/Linux.
Via stackoverflow.com i got to
  https://man7.org/linux/man-pages/man3/ssize_t.3.html
which says
  Include: <sys/types.h>.  Alternatively, <aio.h>, <monetary.h>,
  <mqueue.h>, <stdio.h>, <sys/msg.h>, <sys/socket.h>, <sys/uio.h>, or
  <unistd.h>.

---------------------------------------------------------------------

I wonder why not the many other ssize_t cause problems for you.
The only header files where <unistd.h> is included are "node.h" and
"aaip_0_2.h". So it looks that all other users of ssize_t include one of
them directly or indirectly.
The only libisofs .h file which included <sys/types.h> is again "node.h".
The other candidates don't occur in libisofs .h files.

Next i wonder from where the definition of unsigned size_t comes on
your system. The big man page lists more alternative headers than for
the signed ssize_t.

So i have still some riddle to solve before i release a fix.


Have a nice day :)

Thomas