bug-xorriso
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: xorriso 1.5.6 build issue


From: Rui Chen
Subject: Re: xorriso 1.5.6 build issue
Date: Mon, 12 Jun 2023 22:37:30 -0400

Looks like my patch is still needed, see this test PR, https://github.com/Homebrew/homebrew-core/pull/133445, thanks, Rui

On Mon, Jun 12, 2023 at 11:26 AM Rui Chen <rchen@meetup.com> wrote:
Thanks for the patch upload, I can give it a try. Thanks, Rui

On Mon, Jun 12, 2023 at 11:03 AM Thomas Schmitt <scdbackup@gmx.net> wrote:
Hi,

i now uploaded

  http://www.gnu.org/software/xorriso/xorriso-1.5.6.pl01.tar.gz

with <unistd.h> in libisofs/rockridge.h. It unpacks as directory tree
   ./xorriso-1.5.6
but the resulting binary will report its version as 1.5.6.pl01 .

(Also a new libisofs-1.5.6.pl01.tar.gz was uploaded to libburnia.)

I will probably wait a day or two before announcing the new release.
Curageous users, especially of non-GNU/Linux systems, are invited to
test 1.5.6.pl01 .

--------------------------------------------------------------------------

The miracle success on the GNU/Linux side is caused by <stdio.h> defining
ssize_t on its own and <stdlib.h> including <sys/types.h>.
So rockridge.h has and all other users of ssize_t have it defined when
they encounter the use of ssize_t.

The problem already occured 7 years ago in libisofs/aaip_0_2.h .
Back then it was solved by the same lines as in the patch by Rui Chen.
(Commit 02de4570 in https://dev.lovelyhq.com/libburnia/libisofs.git)
So i included <unicode.h> as tested solution.

The definition of ssize_t in various .c files was quite indirect and thus
rather feeble. So i included <unistd.h> in the needy files of the
development version 1.5.7.
The current development shapshot was renewed:
  http://www.gnu.org/software/xorriso/xorriso-1.5.7.tar.gz


Have a nice day :)

Thomas


reply via email to

[Prev in Thread] Current Thread [Next in Thread]