[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix for over-eager resolution of macro ali
From: |
Felix |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix for over-eager resolution of macro aliases in IR macros |
Date: |
Fri, 10 Aug 2012 11:01:10 +0200 (CEST) |
From: Peter Bex <address@hidden>
Subject: [Chicken-hackers] [PATCH] Fix for over-eager resolution of macro
aliases in IR macros
Date: Thu, 9 Aug 2012 21:06:08 +0200
> Hi all,
>
> Megane found another modules & macros bug in the release candidate.
> I think this is potentially annoying enough to put in the fix before
> making a release (and the fix is conceptually simple enough too, IMO).
>
> The attached patch ensures that symbols which correspond to builtins
> are not renamed directly to the core builtin name (#%* in the example.
> No, I'm not swearing, that's its name). The fix just adds another
> layer of indirection by implicitly renaming these symbols too, to avoid
> capture of the form by outer macros or procedures.
>
> All tests still pass, and the new test passes as well.
Signed off and pushed. I will test it myself and push/tag a new
release candidate (4.8.0rc2) in the "prerelease" branch.
cheers,
felix