[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] fix reexports (somewhat)
From: |
Christian Kellermann |
Subject: |
Re: [Chicken-hackers] [PATCH] fix reexports (somewhat) |
Date: |
Tue, 28 Aug 2012 09:39:33 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* felix winkelmann <address@hidden> [120823 22:02]:
> This patch fixes the bugs #900 and #901 (both reported by megane):
>
> * When reexporting syntax in a module with "*" export list, the syntax
> must be added to the modules' "exist" list, so that it can be retrieved
> on import.
>
> * When reexporting, indirect exports (of the form "(<syntax> <name> ...)")
> must be copied from the module that is reexported into the module that
> reexports, to make them available in the importing module (reexported
> syntactic bindings may refer to indirect exports, but these do not exist
> in the wrapper, the module that does the reexport. Yes, this is quite
> confusing).
>
> Test cases have been added. Note that rexport with renaming is known to
> be broken and likely not to work.
Thanks, I have pushed it. It has been quite large so it took me a
while to understand it. (I still hae to find a nice way to compare
huge patches).
Kind regards,
Christian
--
Be right back -- Godot.