Re: [Chicken-hackers] [PATCH] fix reexports (somewhat)

[Felix]

From: Christian Kellermann <address@hidden>
Subject: Re: [Chicken-hackers] [PATCH] fix reexports (somewhat)
Date: Tue, 28 Aug 2012 09:39:33 +0200

> * felix winkelmann <address@hidden> [120823 22:02]:
>> This patch fixes the bugs #900 and #901 (both reported by megane):
>>
>> * When reexporting syntax in a module with "*" export list, the syntax
>>   must be added to the modules' "exist" list, so that it can be retrieved
>>   on import.
>>
>> * When reexporting, indirect exports (of the form "(<syntax> <name> ...)")
>>   must be copied from the module that is reexported into the module that
>>   reexports, to make them available in the importing module (reexported
>>   syntactic bindings may refer to indirect exports, but these do not exist
>>   in the wrapper, the module that does the reexport. Yes, this is quite
>>   confusing).
>>
>> Test cases have been added. Note that rexport with renaming is known to
>> be broken and likely not to work.
> 
> Thanks, I have pushed it. It has been quite large so it took me a
> while to understand it. (I still hae to find a nice way to compare
> huge patches).

Thanks very much. The patch looked quite involved, but AFAICT it
only modifies the current behaviour for the "reexport" form,
so other parts shouldn't be affected. One never knows for sure,
of course...

What I'm looking for is a decent sexpr-diff...


cheers,
felix