[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Handle EINTR properly in process-wait
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] Handle EINTR properly in process-wait |
Date: |
Fri, 5 Oct 2012 20:18:58 +0200 |
User-agent: |
Mutt/1.4.2.3i |
On Thu, Oct 04, 2012 at 11:45:25PM +0200, Felix wrote:
> Hi!
Hi!
> Both EINTR-related patches have been signed off and pushed.
Thanks!
> John's suggestion might be worth doing - if you agree, go ahead and
> make the necessary changes. I haven't got the time right now to test it.
I thought it would be a good idea and while rearranging the code to
do this, I noticed that the original code is really just ignoring any
kind of other error. This is bad. I've now changed the code to check
for any error, and having the Scheme code check errno. If it's EINTR,
it'll retry, otherwise it'll raise an exception.
Because it's after all a nontrivial modification, I'm submitting it
here for review.
Cheers,
Peter
--
http://sjamaan.ath.cx
--
"The process of preparing programs for a digital computer
is especially attractive, not only because it can be economically
and scientifically rewarding, but also because it can be an aesthetic
experience much like composing poetry or music."
-- Donald Knuth
0001-Convert-errno-EINTR-feof-fp-checks-into-ferror-fp-ch.patch
Description: Text document