chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] file=? function to compare two files


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] file=? function to compare two files
Date: Fri, 25 Jan 2013 19:15:44 +0100
User-agent: Mutt/1.4.2.3i

On Fri, Jan 25, 2013 at 05:22:08PM +0100, Michele La Monaca wrote:
> I wasn't able to spot this kind of function in the library so I wrote it
> myself. Not sure if files.scm is the right place for that. Not sure either
> if inode-numbers equality in Windows is enough to state that two files are
> actually the same file. Some tuning might be needed, not yet very
> fluent/knowledgeable in scheme... unfortunately.

Hi Michele!

Thanks for your contribution!

However, I think this kind of thing isn't needed so often to warrant
inclusion in core.  How about putting it in an egg?

Finally, I only glanced over the code so please excuse me if I overlooked
it, but AFAICT you don't check whether the file sizes are the same.
If they're different, you can do an early return because two differently-
sized files can't possibly be equal.

Cheers,
Peter
-- 
http://sjamaan.ath.cx



reply via email to

[Prev in Thread] Current Thread [Next in Thread]