Re: [Chicken-hackers] [PATCH] fix incorrect type of jmp_buf

[Peter Bex]

On Mon, Jun 17, 2013 at 09:06:11AM +0200, Felix wrote:
> The attached patch fixes a bug in the runtime system: when
> sigsetjmp(3) is used, then "C_restart" and "gc_restart" must be of
> type "sigjmp_buf". Currently they are still declared as "jmp_buf",
> which in most cases will be smaller than a "sigjmp_buf", resulting in
> overwritten memory once a "jmp_buf" is set up.

Oh, that's pretty bad.  I've pushed the patch, with a small cleanup:
where possible, it now uses sizeof(C_restart) instead of the #ifdef stuff.

> This is quite a serious bug, and I recommend putting the patch into
> the stability branch.

+1

Cheers,
Peter
-- 
http://www.more-magic.net