[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Drop requirement on external program dos2u
Re: [Chicken-hackers] [PATCH] Drop requirement on external program dos2unix for tests
Sun, 9 Mar 2014 21:46:48 +0100
On Fri, Mar 07, 2014 at 12:58:02PM +0000, Mario Domenech Goulart wrote:
> On Fri, 7 Mar 2014 13:45:15 +0100 Peter Bex <address@hidden> wrote:
> > How about invoking diff with -w or -b instead? The scrutiny
> > tests only care about the lines emitted, not about whitespace.
> > I don't have access to a Windows VM until Sunday, so I haven't
> > tried this yet but I think it should work and be less hassle.
> Good idea. I'm gonna try that.
I had a look and we're already using diff -w, via DIFF_OPTS which
gets set at the top of runtest.sh.
After simply removing the dos2unix calls, the tests still pass; we're
also using diff to compare dwindtst.expected with dwindtst.out.
The attached patch removes dos2unix and also removes the
differentiation in the r4rstest output, which no longer seems to
be relevant. I suspect this got changed by the removal of gcvt().
Description: Text document