[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Drop requirement on external program dos2u

From: Mario Domenech Goulart
Subject: Re: [Chicken-hackers] [PATCH] Drop requirement on external program dos2unix for tests
Date: Tue, 11 Mar 2014 00:30:47 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

On Sun, 9 Mar 2014 21:46:48 +0100 Peter Bex <address@hidden> wrote:

> On Fri, Mar 07, 2014 at 12:58:02PM +0000, Mario Domenech Goulart wrote:
>> On Fri, 7 Mar 2014 13:45:15 +0100 Peter Bex <address@hidden> wrote:
>> >
>> > How about invoking diff with -w or -b instead?  The scrutiny
>> > tests only care about the lines emitted, not about whitespace.
>> > I don't have access to a Windows VM until Sunday, so I haven't
>> > tried this yet but I think it should work and be less hassle.
>> Good idea.  I'm gonna try that.
> I had a look and we're already using diff -w, via DIFF_OPTS which
> gets set at the top of
> After simply removing the dos2unix calls, the tests still pass; we're
> also using diff to compare dwindtst.expected with dwindtst.out.
> The attached patch removes dos2unix and also removes the
> differentiation in the r4rstest output, which no longer seems to
> be relevant.  I suspect this got changed by the removal of gcvt().

Thanks, Peter.  Tested on Win8.1 32bit (mingw) and Linux x86-64 (gcc and
clang), just in case.  Pushed.

Best wishes.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]