chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix isnormal() on Mingw, restore tests (fi


From: Mario Domenech Goulart
Subject: Re: [Chicken-hackers] [PATCH] Fix isnormal() on Mingw, restore tests (fixing #1062 properly)
Date: Tue, 11 Mar 2014 00:35:12 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

On Fri, 28 Feb 2014 08:41:13 +0100 Peter Bex <address@hidden> wrote:

> On Fri, Feb 28, 2014 at 12:25:07AM +0000, Mario Domenech Goulart wrote:
>> Unfortunately it doesn't work for me.  I get
>> 
>>   Error: assertion failed: (equal? 1.0 (numerator 0.0))
>> 
>> (library tests) for both mingw and mingw-msys (Windows XP 32bit).
>
> Thanks for testing.  This is very strange.  Either one of us messed up
> or it's a Windows XP-specific issue.  Can you try under Windows Vista,
> Windows 7 or Windows 8?  Official support for XP ends this April.
> So I think we shouldn't support it either, and it's not worth testing
> under.
>
> You can download a free as in beer Windows VM for testing purposes in
> various VM formats from http://www.modern.ie

I've done that.  Thanks for the hint and for the patch.

Your patch works fine on Win8.1 32bit, so I pushed it.  Tests will break
on XP, just like before (no real "regression" here, as XP was broken
before this patch).

Best wishes.
Mario
-- 
http://parenteses.org/mario



reply via email to

[Prev in Thread] Current Thread [Next in Thread]