chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Convert (most) core units to modules


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] Convert (most) core units to modules
Date: Sat, 1 Aug 2015 18:08:09 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jul 22, 2015 at 07:40:53PM +1200, Evan Hanson wrote:
> Hi hackers,
> 
> The unit-modules branch has reached a point where I think it'd be good
> to integrate with chicken-5.
[...]
> The code is in the "chicken-5-unit-modules" branch. The tests pass and
> all of the CHICKEN 5-compatible eggs that I've tested work (regex,
> matchable, test, all of release/5/*).

This is excellent work, Evan!  It must have been a massive amount of
work to do this, while keeping everything working correctly.

> A few things to note:
> 
>   - The branch needs to be bootstrapped with itself.
>   - When building a debug chicken, there are now many redefinition
>     warnings. I don't think this is a particularly big deal (after all,
>     they're totally accurate), but if anyone cares I can silence them.
>   - I've followed the pattern for make rules used by Peter's compiler
>     modularisations. Whether that's the best way to do things, IDK.

Yeah, this stuff is pretty ugly and might be in need of a rewrite.
It's just too hairy IMO :)

>   - I haven't updated the manual.

That's fine, since we'll probably end up using a different module
breakdown later on.

This has been merged into the chicken-5 branch.  I've also updated
the DISTFILES definition in order to clean up the generated import
files as well, which is something I forgot to do in my compiler
modularisation branch.  I've added your new generated modules as
well, of course.

Many thanks!

Cheers,
Peter

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]