chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Ensure try-compile cleans up tempfiles (#1213)


From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Ensure try-compile cleans up tempfiles (#1213)
Date: Mon, 24 Aug 2015 21:52:22 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Hi all,

I noticed that try-compile leaves a temp.1234.o file in the current
directory when invoked (see #1213).   The definition actually has a
"oname" variable, but it isn't used.  So the attached patch causes it
to explicitly pass "-o ONAME" to the compiler, to ensure that it
writes to that file (which should now be created under the tempdir
instead of the current directory as an added bonus), and then removes
it.

I've added "shellpath" for good measure.  create-temporary-file should
never create file names which are unsafe to pass to the shell, but when
reading the code that isn't immediately obvious.

Perhaps we should also try adding shellpath to *target-lib-home*, but
I decided to keep this change self-contained and ask, first.

This change should also go into the chicken-5 branch, I think.

Cheers,
Peter

Attachment: 0001-Ensure-try-compile-from-setup-api-cleans-up-tempfile.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]