[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Ensure chicken-install honors -prefix when usi

From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Ensure chicken-install honors -prefix when using -keep-installed (#1144)
Date: Sat, 31 Dec 2016 14:00:37 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

Hi all,

Attached is a pretty straightforward patch to fix #1144.
The problem is that we're using "extension-information"
while walking the egg list to see which eggs already exist.
If extension-information returns a non-#f value, it will
be removed from the list.

When using -prefix, extension-information will still look
in the system-wide directory.  Instead, we had already copied
the body of extension-information into "ext-version" so we
can determine the version of an egg under the prefix.  This
patch simply re-uses that procedure to determine if the egg
exists under the installation directory.

I've done the following tests:

- Installing the egg in the prefix with -keep-installed while it's
   not installed.  It's installed.
- Installing the egg in the prefix with -keep-installed while it
   was already installed.  It's not installed.
- Installing the egg system-wide, then running chicken-install
   with -keep-installed under a prefix.  It's installed.

Seems correct to me.


Attachment: 0001-chicken-install-s-keep-installed-looks-in-prefix.chicken-5.patch
Description: Text Data

Attachment: 0001-chicken-install-s-keep-installed-looks-in-prefix.master.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]