[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Fix record type tags to be nonglobal by mo
From: |
lemonboy |
Subject: |
Re: [Chicken-hackers] [PATCH] Fix record type tags to be nonglobal by module-prefixing them |
Date: |
Sat, 15 Jul 2017 15:48:54 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On 14 Jul, Peter Bex wrote:
> Hi all,
>
> A long time ago, we had a patch that tried to prefix the current module
> name onto a record type's tag (727b2b3fea271474540f215af4842d32e82e7e6d).
>
Awesome news!
A minor nit: the whole module-prefixing dance is repeated three times in this
patch alone, I think it'd be better to reuse the existing but hidden
module-rename: an helper function module-rename/mod that takes a symbol name and
a module (remember that module-name isn't exported) would clear the code a bit
and I'd also need that for another patch :)
> There are two remaining questions:
> - Should the core record types like "promise", "thread" and so on be
> tagged with a module prefix? I think it's fine to keep them the
> way they are.
Why not? If having clear and separate namespaces is the end goal I don't see why
the core should be exempt (besides the fact that the types.db diff is going to
be huge!)