chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix record type tags to be nonglobal by mo


From: Evan Hanson
Subject: Re: [Chicken-hackers] [PATCH] Fix record type tags to be nonglobal by module-prefixing them
Date: Tue, 18 Jul 2017 09:55:21 +1200

Thanks Peter, I've applied this as it is. I agree with Lemon that we
should dry up the repeated naming logic, but for now I think we can live
with the duplication in order to keep things moving.

The patch wasn't quite careful enough with regards to bootstrapping,
however, and caused some problems with our use of `define-record-type`
within core. I've added some compatibility shims where necessary to
allow us to continue bootstrapping from the chicken-5 branch. These can
be removed after another snapshot release.

Regarding whether to namespace the core record types, I think we
probably _should_ do so, but it's not a priority. My attitude towards
wrapping the tags in a record type is similar; I'd be fine with that,
but I also don't see a real need for it, so until there's a clear
benefit to doing so or a lot of time to spare let's leave it alone.

I do think we should make the default record printer omit the namespace
part of the tag, though, so that records continue to be printed as
"#<foo>" and not "#<abc#foo>". I'll post something for this later in the
week, unless anyone else is keen.

Cheers,

Evan

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]