Re: [Chicken-hackers] [PATCH] Fix couple of hangs related to finalizers and (gc #t)

[Peter Bex]

On Sat, Aug 10, 2019 at 08:04:31AM +0300, megane wrote:
> megane <address@hidden> writes:
> >   Also signal an error if trying to re-enter. This also would cause an
> >   infinite loop (when calling (gc #t) inside a finalizer). It would
> >   need special handling if re-entry is to be supported.
> 
> This is too aggressive. The call from ##sys#interrupt-hook should still
> go through without errors. (Think about the case when the thread running
> finalizers gets an interrupt.)
> 
> Attached is a version that doesn't error when re-entering from
> ##sys#interrupt-hook.

Tricky stuff, this!  Thanks for investigating and fixing.  Finally got
around to taking a look at it and now I've pushed this.  Let's check
Salmonella tomorrow and see if nothing breaks, but as far as I can tell
this fix is correct.  On the other hand, I probably would not have
caught the issue with the original patch ;)

Cheers,
Peter

signature.asc
Description: PGP signature