chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Pick rest argument values directly from the argvector withou


From: Peter Bex
Subject: Re: [PATCH] Pick rest argument values directly from the argvector without consing
Date: Wed, 6 Nov 2019 22:03:00 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

On Fri, Nov 01, 2019 at 02:15:51PM +0100, address@hidden wrote:
> Hi!
> 
> 
> Very nice, works well and makes sense. Here a few suggestions:

Thanks for the suggestions, they clean up the code quite a bit.
Attached is a new version of the patch that implements these changes.
I also found out that there was still a bug: when a procedure was
customizable, the generated C rest arg accessor would crash because
there's no "av" nor "c" in those functions.

Can you double-check that the code is correct in the non-"have-av?"
cases in c-backend.scm?  I was unsure if the rest argument is always
tN where N is the number of arguments.

Cheers,
Peter

Attachment: 0001-Replace-car-cdr-null-on-rest-args-with-direct-argvec.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]