[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Clean up some hacks and obsolete code

From: Peter Bex
Subject: Re: [PATCH] Clean up some hacks and obsolete code
Date: Thu, 21 May 2020 12:44:31 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

On Wed, May 20, 2020 at 08:45:51PM +0200, Peter Bex wrote:
> Regarding patch 0002, it looks like we forgot to change
> define-record-printer (perhaps because it, itself is deprecated)
> to use set-record-printer! instead of ##sys#register-record-printer,
> which means we can't remove that definition just yet.

And here's one more patch, because I just realised that CHICKEN wouldn't
compile because it's using that define-record-printer macro internally.
The patch replaces our internal uses of define-record-printer with

More interestingly, it seems that define-record-printer either doesn't
even work, or we're using it wrong somehow:

#;1> (import chicken.irregex)
; loading 
/home/sjamaan/chickens/chicken-5/lib/chicken/11/ ...
#;2> (irregex-match "foo" "foo")
#;3> (interaction-environment)

With patch:

#;1> (import chicken.irregex)
; loading 
/home/sjamaan/chickens/test-5/lib/chicken/11/ ...
#;2> (irregex-match "foo" "foo")
#<regexp-match (0 submatches)>
#;3> (interaction-environment)
#<environment interaction-environment>

No clue why this doesn't work.  I checked, in CHICKEN 4 this worked,
so I think we broke this somewhere during our massive CHICKEN 5 changes.
I'm not sure it's worth fixing this, considering define-record-printer is
obsolete anyway.  Presumably nobody is using it, or this would've been
reported already?


Attachment: 0003-Use-set-record-printer-instead-of-define-record-prin.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]