chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Clean up some hacks and obsolete code


From: Peter Bex
Subject: Re: [PATCH] Clean up some hacks and obsolete code
Date: Fri, 22 May 2020 08:48:21 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

On Thu, May 21, 2020 at 03:12:33PM -0500, Jim Ursetto wrote:
> Hey Peter,

Hi Jim,

Good to see you're back!

> I might be misunderstanding, but quite a few Chicken 5 eggs still use 
> define-record-printer, and it seems to work fine in Chicken 5.1.0 and 5.2.0.

hm, maybe it's just the way we used it in core that's wrong?  I dunno.

I can't really explain it because the expansion looks fine and
is the same as the one in sql-de-lite.

Anyway, good to know that it's not completely broken.

> I’d be amenable to replacing this with set-record-printer! in my eggs for 
> Chicken 5 (I was unaware this was deprecated), but you’d have to hunt down a 
> lot of references if you want to remove it.

We can keep a long deprecation period.  This patch just removes usages
in core and updates the macro so we can get rid of the obsolete alias.

Cheers,
Peter

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]