Re: [PATCH] ensure correct install command is used on Windows in egg install script

[Mario Domenech Goulart]

Hi Felix,

On Tue, 07 Sep 2021 10:16:12 +0200 felix.winkelmann@bevuta.com wrote:

>> I could not apply this patch on master.  `install-executable-command'
>> and `install-file-command'  don't have a `case' form matching
>> `platform' in master.  Maybe another patch is missing?
>> 
>
> Here is another version. I forgot to clean up my repository from previous
> work - I'm still able to screw up nearly every non-trivial git workflow.
>
> I hope this one works.

Thanks.  It didn't work on Linux, as there was a spurious `d' given as
argument to string-append.  `d' is bound to a procedure (probably in
chicken-install.scm, which includes egg-compile.scm).  That caused the
following error when installing eggs:

  Error: (string-append) bad argument type - not a string: #<procedure>

After I removed the `d' given as argument to string-append things worked
fine on Linux.  I haven't tested the patch on Windows (it looks fine to
me, though).

Since I touched the patch, I went ahead and performed some additional
editorial nitpickery (nuked spurious whitespaces, fixed indentation and
broke the commit message into summary and body).

The revised and signed-off patch is attached.  Feel free to push it if
you agree with the modifications.

All the best.
Mario
-- 
http://parenteses.org/mario

0001-Ensure-platform-identifier-is-used-when-determining-.patch
Description: Text Data