[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inetlib build fixes

From: Michael Koch
Subject: Re: inetlib build fixes
Date: Fri, 9 Jan 2004 09:23:22 +0100
User-agent: Mutt/1.3.28i

On Thu, Jan 08, 2004 at 06:26:09PM +0100, Chris Burdess wrote:

Several comments on your patch:

- ChangeLog entry missing.

- unified diffs are much more readable (preferable with 3 lines of

- Generated files are normally excluded from posted patches. The only
  bloat the patch and give nothing new.

I haven't tried to understand the patch yet but I think as
it is your code you are the one to approve it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]