commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inetlib build fixes


From: Chris Burdess
Subject: Re: inetlib build fixes
Date: Sat, 10 Jan 2004 13:07:29 +0100

Michael Koch wrote:
Several comments on your patch:

- ChangeLog entry missing.

now added.

- unified diffs are much more readable (preferable with 3 lines of
  context)

ok, i'll do that in future.

- Generated files are normally excluded from posted patches. The only
  bloat the patch and give nothing new.

that makes sense.

I haven't tried to understand the patch yet but I think as
it is your code you are the one to approve it.

is there a procedure for that?

thanks for the comments,
--
Chris Burdess





reply via email to

[Prev in Thread] Current Thread [Next in Thread]