[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[commit-cp] [patch #3614] DefaultTableModel - fixes and Javadocs
From: |
anonymous |
Subject: |
[commit-cp] [patch #3614] DefaultTableModel - fixes and Javadocs |
Date: |
Thu, 06 Jan 2005 14:14:17 -0500 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041111 Firefox/1.0 |
This mail is an automated notification from the patch tracker
of the project: classpath.
/**************************************************************************/
[patch #3614] Latest Modifications:
Changes by: Anonymous user
Date:
Thu 01/06/2005 at 14:02
------------------ Additional Follow-up Comments ----------------------------
I looked into this patch and it looks very good. I made few minor changes to
replace fileTableChanged(new TableModelEvent(...)) calls to
call methods already implemented in AbstractTableModel.
i.e.
< + fireTableCellUpdated(row,column);
---
> + fireTableChanged(
> + new TableModelEvent(this, row, row, column, TableModelEvent.UPDATE)
> + );
This patch is now committed to java-gui-branch
/**************************************************************************/
[patch #3614] Full Item Snapshot:
URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=3614>
Project: classpath
Submitted by: David Gilbert
On: Tue 01/04/2005 at 16:57
Category: None
Priority: 1 - Later
Resolution: None
Privacy: Public
Assigned to: None
Originator Email:
Status: Open
Summary: DefaultTableModel - fixes and Javadocs
Original Submission: This patch fixes assorted problems with the
DefaultTableModel class (Mauve tests will be committed shortly) and adds
Javadocs to the class (and also the TableModel interface). Changelog entry is:
2005-01-04 David Gilbert <address@hidden>
* javax/swing/table/DefaultTableModel.java
(DefaultTableModel()): Added Javadocs.
(DefaultTableModel(int, int)): Fixed implementation.
(DefaultTableModel(Vector, int)): Throw IllegalArgumentException
for negative rowCount.
(DefaultTableModel(Object[], int)): Added Javadocs.
(DefaultTableModel(Vector, Vector)): Likewise.
(DefaultTableModel(Object[][], Object[])): Likewise.
(getDataVector): Likewise.
(setDataVector(Vector, Vector)): Likewise.
(setDataVector(Object[][], Object[])): Likewise.
(newDataAvailable): Likewise.
(newRowsAdded): Likewise.
(rowsRemoved): Likewise.
(setColumnIdentifiers(Vector)): Allow for null argument.
(setColumnIdentifiers(Object[])): Added Javadocs.
(setNumRows): Likewise.
(setRowCount): Adds new rows if necessary, and sends more specific
TableModelEvent.
(setColumnCount): Allow for null columnIdentifiers.
(addColumn(Object)): Added Javadocs.
(addColumn(Object, Vector)): Handle null columnData.
(addColumn(Object, Object[])): Handle columnData with more or less
entries than rows in the table.
(addRow(Vector)): Fire appropriate event.
(addRow(Object[])): Added Javadocs.
(insertRow(int, Vector)): Fire appropriate event.
(insertRow(int, Object[])): Added Javadocs.
(moveRow): Reimplemented.
(removeRow(int)): Fire appropriate event.
(getColumnCount): Allow for null columnIdentifiers.
(getColumnName): Now returns empty string when column index is too
large.
(isCellEditable): Added Javadocs.
(getValueAt): Likewise.
(setValueAt): Fire more specific event.
(convertToVector): Added Javadocs.
* javax/swing/table/TableModel.java
Added Javadocs.
Follow-up Comments
------------------
-------------------------------------------------------
Date: Thu 01/06/2005 at 14:02 By: 0 <None>
I looked into this patch and it looks very good. I made few minor changes to
replace fileTableChanged(new TableModelEvent(...)) calls to
call methods already implemented in AbstractTableModel.
i.e.
< + fireTableCellUpdated(row,column);
---
> + fireTableChanged(
> + new TableModelEvent(this, row, row, column, TableModelEvent.UPDATE)
> + );
This patch is now committed to java-gui-branch
-------------------------------------------------------
Date: Wed 01/05/2005 at 05:17 By: David Gilbert <trebligd>
OK, thanks! The Mauve tests that drive the changes I made in the attached
patch have now been committed to Mauve CVS.
-------------------------------------------------------
Date: Tue 01/04/2005 at 17:09 By: Michael Koch <mkoch>
Patch forwarded to Olga as she works on this since a longer time already and
surely knows more about it.
File Attachments
-------------------
-------------------------------------------------------
Date: Tue 01/04/2005 at 16:57 Name: patch.txt Size: 23.87KB By: trebligd
http://savannah.gnu.org/patch/download.php?item_id=3614&item_file_id=3995
For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=3614>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/