Re: [PATCH 16/17] tests: more resilient about tainted absolute srcdir path

[Andreas Schwab]

Jim Meyering <address@hidden> writes:

> Stefano Lattarini wrote:
>> * tests/init.cfg (stty_reversible_init_): Quote '$abs_top_srcdir'
>> properly.
>> (fiemap_capable_): Quote '$abs_srcdir' properly.
>> (require_dirent_d_type_): Likewise.
>> ---
>>  init.cfg | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/init.cfg b/init.cfg
>> index 7edfd0f..13cac74 100644
>> --- a/init.cfg
>> +++ b/init.cfg
>> @@ -266,7 +266,7 @@ stty_reversible_init_()
>>  {
>>    # Pad start with one space for the first option to match in query 
>> function.
>>    stty_reversible_=' '$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
>> -    $abs_top_srcdir/src/stty.c | tr '\n' ' ')
>> +    "$abs_top_srcdir"/src/stty.c | tr '\n' ' ')
> ...
>
> Thanks, but this c-set is unnecessary, since configure itself verifies
> the sanity of $srcdir and $abs_top_srcdir:

Except that $abs_top_srcdir may contain spaces.

Andreas.

-- 
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."