[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/17] tests: more resilient about tainted absolute srcdir pa
From: |
Jim Meyering |
Subject: |
Re: [PATCH 16/17] tests: more resilient about tainted absolute srcdir path |
Date: |
Tue, 04 Sep 2012 17:51:44 +0200 |
Andreas Schwab wrote:
> Jim Meyering <address@hidden> writes:
>
>> Stefano Lattarini wrote:
>>> * tests/init.cfg (stty_reversible_init_): Quote '$abs_top_srcdir'
>>> properly.
>>> (fiemap_capable_): Quote '$abs_srcdir' properly.
>>> (require_dirent_d_type_): Likewise.
>>> ---
>>> init.cfg | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/init.cfg b/init.cfg
>>> index 7edfd0f..13cac74 100644
>>> --- a/init.cfg
>>> +++ b/init.cfg
>>> @@ -266,7 +266,7 @@ stty_reversible_init_()
>>> {
>>> # Pad start with one space for the first option to match in query
>>> function.
>>> stty_reversible_=' '$(perl -lne '/^ *{"(.*?)",.*\bREV\b/ and print $1' \
>>> - $abs_top_srcdir/src/stty.c | tr '\n' ' ')
>>> + "$abs_top_srcdir"/src/stty.c | tr '\n' ' ')
>> ...
>>
>> Thanks, but this c-set is unnecessary, since configure itself verifies
>> the sanity of $srcdir and $abs_top_srcdir:
>
> Except that $abs_top_srcdir may contain spaces.
So it does! Good catch.
I'll reinsert that patch. Thank you.
- [PATCH 11/17] tests: put test-suite.log back in 'tests/', (continued)
- [PATCH 11/17] tests: put test-suite.log back in 'tests/', Stefano Lattarini, 2012/09/02
- [PATCH 12/17] build: remove two now-useless convenience targets, Stefano Lattarini, 2012/09/02
- [PATCH 14/17] maint: avoid a spurious syntax-check error, Stefano Lattarini, 2012/09/02
- [PATCH 13/17] maint: vc_exe_in_TESTS should actually be a syntax check, Stefano Lattarini, 2012/09/02
- [PATCH 15/17] maint: fix syntax checks 'sc_root_tests', Stefano Lattarini, 2012/09/02
- [PATCH 17/17] maint: fix a spurious syntax-check failure, Stefano Lattarini, 2012/09/02
- [PATCH 16/17] tests: more resilient about tainted absolute srcdir path, Stefano Lattarini, 2012/09/02
- [PATCH 10/17] build: don't use recursive make fore 'tests' subdirectory, Stefano Lattarini, 2012/09/02
- Re: [PATCH 00/17] De-recursion for the 'tests' subdirectory., Jim Meyering, 2012/09/03
- Message not available
- Re: [PATCH 00/17] De-recursion for the 'tests' subdirectory., Stefano Lattarini, 2012/09/04
- Message not available
- Re: [PATCH 00/17] De-recursion for the 'tests' subdirectory., Stefano Lattarini, 2012/09/04
- Re: [PATCH 00/17] De-recursion for the 'tests' subdirectory., Jim Meyering, 2012/09/04