Re: [Dragora-users] [Bug] efivar package doesn't install efivar-guids.h file

[DustDFG]

Thank you very much!

I can't understand why you commented line with patch applying instead
of delete it.

On Fri, May 20, 2022 at 10:50 PM Matías Fonzo <selk@dragora.org> wrote:
>
> El 2022-05-16 11:21, DustDFG escribió:
> > On Mon, May 16, 2022 at 3:02 PM Matías Fonzo <selk@dragora.org> wrote:
> >>
> >> El 2022-05-16 10:58, DustDFG escribió:
> >> > Hello!
> >> >
> >> > On Mon, May 16, 2022 at 2:02 PM Matías Fonzo <selk@dragora.org> wrote:
> >> >>
> >> >> El 2022-05-08 05:31, DustDFG escribió:
> >> >> > Hello!
> >> >> >
> >> >> > / - is root of package build directory
> >> >> >
> >> >> > The efivar package creates file `/src/include/efivar/efivar-guids.h`.
> >> >> > The
> >> >> > package must install all files from `/src/include/efivar/` (you can
> >> >> > find
> >> >> > them in `/usr/include/efivar` after installing package) but I can't
> >> >> > find
> >> >> > the efivar-guids.h. It exists in build directory but it doesn't exist
> >> >> > in
> >> >> > system after installing. I don't know why...
> >> >>
> >> >> I haven't had time to look through this yet, as soon as I can I will.
> >> >> In the meantime feel free to make a Pull Request (if this header is
> >> >> really needed).
> >> >>
> >> >>
> >> >
> >> > The efibootmgr needs this header file. I can add to the recipe line
> >> > with `cp` command and leave there comment about this bug. Will it be
> >> > ok?
> >>
> >> Yeah, sure.  If it's not installed by default, probably is because is
> >> missing from the build system...
> >>
> >
> > I tried to find the root of the bug in the build system. I am not
> > expert (I am not a programmer or a system administrator) but the build
> > system looks like this file will be copied (but it doesn't copy)...
>
> I discovered that the problem was in the recipe instruction, by assuming
> that the "target" install for make(1) satisfies the requirements or
> prerequisites to build the source.  I have now fixed it[1] (by passing
> another instruction for make(1)), plus I have updated the source to get
> the changes from upstream[2].
>
> [1]
> http://git.savannah.nongnu.org/cgit/dragora.git/plain/recipes/boot/efivar/recipe?id=05b34c50c4845808892997365fe2f25c155ed4a5
> [2]
> http://git.savannah.nongnu.org/cgit/dragora.git/commit/?id=05b34c50c4845808892997365fe2f25c155ed4a5
>
> I suggest that you use "make ; make install" to ensure a build.
>
>