bug#41945: closed (guix deploy --dry-run: unrecognized option)

[GNU bug Tracking System]

Your message dated Mon, 25 Jul 2022 08:31:50 -0400
with message-id <871qu99xvt.fsf@gmail.com>
and subject line Re: bug#44893: `guix deploy` doesn't recognize option --dry-run
has caused the debbugs.gnu.org bug report #44893,
regarding guix deploy --dry-run: unrecognized option
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
44893: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44893
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> guix deploy --dry-run: unrecognized option
>
>
>
>
> Date: 
>
> Thu, 18 Jun 2020 23:36:17 -0400
>
>
>
>
> Hello!
>
> guix deploy --help says it supports a --dry-run version (or -n), but it
> fails to live up to it:
>
> guix deploy --dry-run my-machine.scm
>
> guix deploy: error: dry-run: unrecognized option
>
> Maxim
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#44893: `guix deploy` doesn't recognize option --dry-run
>
>
>
>
> Date: 
>
> Mon, 25 Jul 2022 08:31:50 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)
>
>
>
>
> Hi,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Hi,
> >
> > We can make this change:
> >
> > diff --git a/guix/scripts/deploy.scm b/guix/scripts/deploy.scm
> > index 0725fba54b..d9371b3d4a 100644
> > --- a/guix/scripts/deploy.scm
> > +++ b/guix/scripts/deploy.scm
> > @@ -165,7 +165,9 @@ Perform the deployment specified by FILE.\n"))
> >            (with-build-handler (build-notifier #:use-substitutes?
> >                                                (assoc-ref opts 'substitutes?)
> >                                                #:verbosity
> > -                                              (assoc-ref opts 'verbosity))
> > +                                              (assoc-ref opts 'verbosity)
> > +                                              #:dry-run?
> > +                                              (assoc-ref opts 'dry-run?))
> >              (parameterize ((%graft? (assq-ref opts 'graft?)))
> >                (map/accumulate-builds store
> >                                       (cut deploy-machine* store <>)
> >
> >
> > It may not be the kind of “dry run” that users have in mind for ‘guix
> > deploy’, as you note zimoun, but that’s probably better than nothing.
> >
> > Thoughts?
>
> I see such a fix was pushed as ff94f9dfde; closing!
>
> Thank you,
>
> Maxim
>
>
> --- End Message ---