--- Begin Message ---
|
Subject: |
[PATCH] 29.0.50; compile.el doesn't always clean up after itself |
|
Date: |
Fri, 22 Jul 2022 09:26:34 +0100 |
Hello maintainers,
compile.el, which runs user code, doesn't use `unwind-protect` in its
process sentinel. I really think it should.
I noticed this while playing around with the excellent rmsbolt.el of Jay
Kamat, which makes use of compilation-finish-functions. If ones of
these functions errors, the user is stuck with a "[Compiling]" in her
modeline, even if compilation has long finished.
Let me know if there are any objections to this patch:
>From de8025f19a7fe0cc37beeed61f4c1269de3519af Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20T=C3=A1vora?= <joaotavora@gmail.com>
Date: Fri, 22 Jul 2022 09:23:02 +0100
Subject: [PATCH] Clean up more robustly in compile.el
* lisp/progmodes/compile.el (compilation-sentinel): Use
unwind-protect.
---
lisp/progmodes/compile.el | 31 ++++++++++++++++---------------
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index c71a50d4fd..a665fccc73 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2464,22 +2464,23 @@ compilation-handle-exit
(defun compilation-sentinel (proc msg)
"Sentinel for compilation buffers."
(if (memq (process-status proc) '(exit signal))
- (let ((buffer (process-buffer proc)))
- (if (null (buffer-name buffer))
- ;; buffer killed
- (set-process-buffer proc nil)
- (with-current-buffer buffer
- ;; Write something in the compilation buffer
- ;; and hack its mode line.
- (compilation-handle-exit (process-status proc)
- (process-exit-status proc)
- msg)
- ;; Since the buffer and mode line will show that the
- ;; process is dead, we can delete it now. Otherwise it
- ;; will stay around until M-x list-processes.
- (delete-process proc)))
+ (unwind-protect
+ (let ((buffer (process-buffer proc)))
+ (if (null (buffer-name buffer))
+ ;; buffer killed
+ (set-process-buffer proc nil)
+ (with-current-buffer buffer
+ ;; Write something in the compilation buffer
+ ;; and hack its mode line.
+ (compilation-handle-exit (process-status proc)
+ (process-exit-status proc)
+ msg))))
(setq compilation-in-progress (delq proc compilation-in-progress))
- (compilation--update-in-progress-mode-line))))
+ (compilation--update-in-progress-mode-line)
+ ;; Since the buffer and mode line will show that the
+ ;; process is dead, we can delete it now. Otherwise it
+ ;; will stay around until M-x list-processes.
+ (delete-process proc))))
(defun compilation-filter (proc string)
"Process filter for compilation buffers.
--
2.37.0
João
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#56696: [PATCH] 29.0.50; compile.el doesn't always clean up after itself |
|
Date: |
Mon, 25 Jul 2022 14:20:19 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
João Távora <joaotavora@gmail.com> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> João Távora <joaotavora@gmail.com> writes:
>>
>>> Let me know if there are any objections to this patch:
>>
>> Looks good to me.
>
> It seems it helps, but doesn't quite fix the problem I'm experiencing,
> so I'll play around with it some more and see if I can improve it.
Nevermind, the patch is fine, the persistent problem I was still seeing
was due to some mischief by the client of compile.el.
Pushed. Commit ffe12ff250
Thanks,
João
--- End Message ---