[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: view/edit large files
From: |
Eli Zaretskii |
Subject: |
Re: view/edit large files |
Date: |
Tue, 17 Feb 2009 21:47:46 +0200 |
> From: Stefan Monnier <address@hidden>
> Date: Tue, 17 Feb 2009 14:23:32 -0500
> Cc: address@hidden
>
> + off_t beg_offset, end_offset;
Is off_t guaranteed to be 64-bit wide? If not, we lose the advantage
of the floats, no?
> + beg_offset = FLOATP (beg) ? (off_t) XFLOAT_DATA (beg) : XINT (beg);
> + end_offset = FLOATP (end) ? (off_t) XFLOAT_DATA (end) : XINT (end);
Shouldn't we round rather than truncate, when converting to off_t?
> - if (XINT (beg) != 0)
> + if (beg_offset != 0)
Exact equalities might be dangerous with floats.
> - if (same_at_start - BEGV_BYTE == XINT (end))
> + if (same_at_start - BEGV_BYTE == end_offset - beg_offset)
Likewise.
> - if (XINT (beg) != 0 || !NILP (replace))
> + if (beg_offset != 0 || !NILP (replace))
Likewise.
- Re: view/edit large files, (continued)
- Re: view/edit large files, Miles Bader, 2009/02/06
- Re: view/edit large files, Ted Zlatanov, 2009/02/09
- Re: view/edit large files, Stefan Monnier, 2009/02/09
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Miles Bader, 2009/02/10
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Miles Bader, 2009/02/10
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Ted Zlatanov, 2009/02/10
- Re: view/edit large files, Stefan Monnier, 2009/02/17
- Re: view/edit large files,
Eli Zaretskii <=
- Re: view/edit large files, Miles Bader, 2009/02/17
- Re: view/edit large files, Eli Zaretskii, 2009/02/17
- Re: view/edit large files, Miles Bader, 2009/02/17
- Re: view/edit large files, Miles Bader, 2009/02/17
- Re: view/edit large files, Eli Zaretskii, 2009/02/17
- Re: view/edit large files, Stefan Monnier, 2009/02/17
- Re: view/edit large files, Ted Zlatanov, 2009/02/20
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Miles Bader, 2009/02/10
- Re: view/edit large files (was: map-file-lines), Richard M Stallman, 2009/02/07