[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: view/edit large files
From: |
Eli Zaretskii |
Subject: |
Re: view/edit large files |
Date: |
Tue, 17 Feb 2009 22:51:06 +0200 |
> From: Miles Bader <address@hidden>
> Date: Wed, 18 Feb 2009 05:18:03 +0900
>
> Eli Zaretskii <address@hidden> writes:
> >> + off_t beg_offset, end_offset;
> >
> > Is off_t guaranteed to be 64-bit wide? If not, we lose the advantage
> > of the floats, no?
>
> If the system isn't capable of handling large files at all, then there's
> no point in worrying about it, right?
Some systems can handle large files, but only if you use something
like off64_t.
> >> + beg_offset = FLOATP (beg) ? (off_t) XFLOAT_DATA (beg) : XINT (beg);
> >> + end_offset = FLOATP (end) ? (off_t) XFLOAT_DATA (end) : XINT (end);
> >
> > Shouldn't we round rather than truncate, when converting to off_t?
>
> No. The values being represented are integers. The user almost
> certainly will not be passing in a non-integral float
I was thinking about 1234.99999 or some such, due to inaccuracies in
converting textual representation into a float.
> Maybe it should guard against overflow in the conversion though (and
> signal an error?).
Yes, probably.
- Re: view/edit large files, (continued)
- Re: view/edit large files, Stefan Monnier, 2009/02/09
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Miles Bader, 2009/02/10
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Miles Bader, 2009/02/10
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Ted Zlatanov, 2009/02/10
- Re: view/edit large files, Stefan Monnier, 2009/02/17
- Re: view/edit large files, Eli Zaretskii, 2009/02/17
- Re: view/edit large files, Miles Bader, 2009/02/17
- Re: view/edit large files,
Eli Zaretskii <=
- Re: view/edit large files, Miles Bader, 2009/02/17
- Re: view/edit large files, Miles Bader, 2009/02/17
- Re: view/edit large files, Eli Zaretskii, 2009/02/17
- Re: view/edit large files, Stefan Monnier, 2009/02/17
- Re: view/edit large files, Ted Zlatanov, 2009/02/20
- Re: view/edit large files, Eli Zaretskii, 2009/02/10
- Re: view/edit large files, Miles Bader, 2009/02/10
- Re: view/edit large files (was: map-file-lines), Richard M Stallman, 2009/02/07
- Re: view/edit large files, Ted Zlatanov, 2009/02/09
- Re: view/edit large files, Richard M Stallman, 2009/02/10