Re: send new reply from gnus hangs

[Óscar Fuentes]

Confirmed, reverting that commit fixes the problem.

Óscar Fuentes <address@hidden> writes:

> Óscar Fuentes <address@hidden> writes:
>
>>>>>>> Andy Moreton <address@hidden> writes:
>>>>>>>
>>>>>>>> A recent change on the master branch (within the last week) prevents
>>>>>>>> gnus from sending replies to newsgroups - it gets stuck with
>>>>>>>> "sending..." in the message area.
>>>>>>>>
>>>>>>>> I've looked at the recent commits that might affect gnus, but nothing
>>>>>>>> obvious jumps out. I'm not sure what the problem is or how to start
>>>>>>>> debugging it.
>>>>>>>>
>>>>>>>> Does anyone have any ideas ?
>>>>>>>
>>>>>>> git bisect
>
> The problematic commit is
>
> master e51adfbdb7587c2b0b5ba154be210b30db82b4ea
> Author:     Oleh Krehel <address@hidden>
> AuthorDate: Thu Jun 6 16:01:10 2019 +0200
> Commit:     Oleh Krehel <address@hidden>
> CommitDate: Thu Jun 6 16:01:10 2019 +0200
>
> Parent:     e188f08fcd lisp/gnus/message.el (message--fold-long-headers): Add 
> docstring
> Merged:     emacs-26 master
> Containing: master
> Follows:    emacs-26.1 (5471)
>
> lisp/gnus/message.el (message--check-continuation-headers): Extract
>
> 1 file changed, 13 insertions(+), 21 deletions(-)
> lisp/gnus/message.el | 34 +++++++++++++---------------------
>
> modified   lisp/gnus/message.el
> @@ -4476,6 +4476,17 @@ message-send-mail-partially
>  
>  (declare-function hashcash-wait-async "hashcash" (&optional buffer))
>  
> +(defun message--check-continuation-headers ()
> +  (message-check 'continuation-headers
> +    (goto-char (point-min))
> +    (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t)
> +      (goto-char (match-beginning 0))
> +      (if (y-or-n-p "Fix continuation lines? ")
> +          (insert " ")
> +        (forward-line 1)
> +        (unless (y-or-n-p "Send anyway? ")
> +          (error "Failed to send the message"))))))
> +
>  (defun message-send-mail (&optional _)
>    (require 'mail-utils)
>    (let* ((tembuf (message-generate-new-buffer-clone-locals " message temp"))
> @@ -4527,15 +4538,7 @@ message-send-mail
>            (if news nil message-deletable-headers)))
>       (message-generate-headers headers))
>        ;; Check continuation headers.
> -      (message-check 'continuation-headers
> -     (goto-char (point-min))
> -     (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t)
> -       (goto-char (match-beginning 0))
> -       (if (y-or-n-p "Fix continuation lines? ")
> -           (insert " ")
> -         (forward-line 1)
> -         (unless (y-or-n-p "Send anyway? ")
> -           (error "Failed to send the message")))))
> +      (message--check-continuation-headers)
>        (message--fold-long-headers)
>        ;; Let the user do all of the above.
>        (run-hooks 'message-header-hook))
> @@ -5159,18 +5162,7 @@ message-check-news-header-syntax
>          (if (= (length errors) 1) "this" "these")
>          (if (= (length errors) 1) "" "s")
>          (mapconcat 'identity errors ", ")))))))
> -   ;; Check continuation headers.
> -   (message-check 'continuation-headers
> -     (goto-char (point-min))
> -     (let ((do-posting t))
> -       (while (re-search-forward "^[^ \t\n][^ \t\n:]*[ \t\n]" nil t)
> -      (goto-char (match-beginning 0))
> -      (if (y-or-n-p "Fix continuation lines? ")
> -          (insert " ")
> -        (forward-line 1)
> -        (unless (y-or-n-p "Send anyway? ")
> -          (setq do-posting nil))))
> -       do-posting))
> +   (message--check-continuation-headers)
>     ;; Check the Newsgroups & Followup-To headers for syntax errors.
>     (message-check 'valid-newsgroups
>       (let ((case-fold-search t)