emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build: other output


From: Lars Ingebrigtsen
Subject: Re: Towards a cleaner build: other output
Date: Mon, 17 Jun 2019 22:27:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

OK, with the patch below I now get

  GEN      loaddefs.el
Not registering prefix "lo" from completion.  Affects: 
("locate-completion-entry" "locate-completion-entry-retry" 
"locate-completion-db-error" "load-completions-from-file")
  INFO     Processed 100 completions from files
Not registering prefix "*" from ielm.  Affects: ("*" "**" "***" "*1" "*2" "*3")
  INFO     Processed 200 completions from files
  INFO     Processed 300 completions from files
  INFO     Processed 400 completions from files
  INFO     Processed 500 completions from files
  INFO     Processed 600 completions from files
  INFO     Processed 700 completions from files
  INFO     Processed 800 completions from files
Not registering prefix "is" from ind-util.  Affects: 
("is13194-default-repertory" "is13194-repertory-to-ucs-script" 
"is13194-to-ucs-devanagari-hashtbl" "is13194-to-ucs-devanagari-regexp" 
"is13194-to-ucs-bengali-hashtbl" "is13194-to-ucs-bengali-regexp" 
"is13194-to-ucs-assamese-hashtbl" "is13194-to-ucs-assamese-regexp" 
"is13194-to-ucs-gurmukhi-hashtbl" "is13194-to-ucs-gurmukhi-regexp" 
"is13194-to-ucs-gujarati-hashtbl" "is13194-to-ucs-gujarati-regexp" 
"is13194-to-ucs-oriya-hashtbl" "is13194-to-ucs-oriya-regexp" 
"is13194-to-ucs-tamil-hashtbl" "is13194-to-ucs-tamil-regexp" 
"is13194-to-ucs-telugu-hashtbl" "is13194-to-ucs-telugu-regexp" 
"is13194-to-ucs-malayalam-hashtbl" "is13194-to-ucs-malayalam-regexp" 
"is13194-to-ucs-kannada-hashtbl" "is13194-to-ucs-kannada-regexp" 
"iscii-to-ucs-region")
  INFO     Processed 900 completions from files
  INFO     Processed 1000 completions from files
  INFO     Processed 1100 completions from files
  INFO     Processed 1200 completions from files
  INFO     Processed 1300 completions from files
Not registering prefix "se" from page-ext.  Affects: ("search-pages" 
"set-page-delimiter")
  INFO     Processed 1400 completions from files
make[3]: Leaving directory '/home/larsi/src/emacs/trunk/lisp'
  GEN      ../etc/DOC

This part of the compilation takes about 30 seconds on my faster
machine.

I don't see much value in the "Not registering" messages, because I
don't see how any developer would respond to the output, but I may be
totally wrong here.

Does the INFO thing look reasonable?

diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el
index 19e1e93621..8c9c53c6e5 100644
--- a/lisp/emacs-lisp/autoload.el
+++ b/lisp/emacs-lisp/autoload.el
@@ -1061,6 +1061,7 @@ update-directory-autoloads
          ;; Files with no autoload cookies or whose autoloads go to other
          ;; files because of file-local autoload-generated-file settings.
         (no-autoloads nil)
+         (file-count 0)
          (autoload-modified-buffers nil)
         (generated-autoload-file
          (if (called-interactively-p 'interactive)
@@ -1126,6 +1127,10 @@ update-directory-autoloads
       ;; Elements remaining in FILES have no existing autoload sections yet.
       (let ((no-autoloads-time (or last-time '(0 0 0 0))) file-time)
        (dolist (file files)
+          (setq file-count (1+ file-count))
+          (when (zerop (mod file-count 100))
+            (byte-compile-info-message "Processed %d completions from files"
+                                       file-count))
          (cond
           ;; Passing nil as second argument forces
           ;; autoload-generate-file-autoloads to look for the right
diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el
index 3a2043bad7..30a9f98479 100644
--- a/lisp/emacs-lisp/byte-run.el
+++ b/lisp/emacs-lisp/byte-run.el
@@ -540,6 +540,10 @@ byte-run--unescaped-character-literals-warning
                         (mapconcat (lambda (char) (format "`?\\%c'" char))
                                    sorted ", ")))))
 
+(defun byte-compile-info-message (&rest args)
+  "Message format ARGS in a way that looks pleasing in the compilation output."
+  (message "%s" (concat "  INFO     " (apply #'format args))))
+
 
 ;; I nuked this because it's not a good idea for users to think of using it.
 ;; These options are a matter of installation preference, and have nothing to


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




reply via email to

[Prev in Thread] Current Thread [Next in Thread]