Re: master b9ac4f8: Fix locating pdump by symlink

[Robert Pluim]

>>>>> On Mon, 24 Jun 2019 16:01:11 +0100, "Basil L. Contovounesios" 
>>>>> <address@hidden> said:

    Basil> Robert Pluim <address@hidden> writes:
    >>>>>>> On Sun, 23 Jun 2019 21:19:26 -0400 (EDT), address@hidden (Daniel 
Colascione) said:
    >> 
    Daniel> branch: master
    Daniel> commit b9ac4f815ebaa1acb0d045fe9583f665efa6f628
    Daniel> Author: Daniel Colascione <address@hidden>
    Daniel> Commit: Daniel Colascione <address@hidden>
    >> 
    Daniel> Fix locating pdump by symlink
    >> 
    Daniel> * admin/merge-gnulib (GNULIB_MODULES): Add canonicalize-lgpl module
    Daniel> * build-aux/config.guess, build-aux/gitlog-to-changelog,
    Daniel> build-aux/update-copyright, lib/canonicalize-lgpl.c,
    Daniel> lib/gnulib.mk.in, lib/malloca.c, lib/malloca.h, lib/pathmax.h,
    Daniel> m4/canonicalize.m4, m4/double-slash-root.m4, m4/gnulib-comp.m4,
    Daniel> m4/malloca.m4, my/pathmax.4: copy from GNUlib or regenerate from
    Daniel> update
    Daniel> * src/emacs.c: find dump by canonical path
    >> 
    >> I guess something went wrong in the addition of malloca.c to the
    >> build:
    >> 
    >> CCLD     temacs
    >> Undefined symbols for architecture x86_64:
    >> "_freea", referenced from:
    >> _rpl_realpath in libgnu.a(canonicalize-lgpl.o)
    >> ld: symbol(s) not found for architecture x86_64
    >> 
    >> (this is on macOS)

    Basil> See also bug#36356:
    Basil> https://debbugs.gnu.org/36356

Indeed. Paul has fixed this with 848ff94b45

Robert