Re: master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO.

[Stefan Kangas]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 21.09.2020 17:46, Stefan Kangas wrote:
>> +;; TODO: Convert these into unit proper tests instead of using an
>> +;;       external file.
>
> I wonder: did we ever decide to switch from manual/indent tests to ERT
> tests wholesale?

I was working under the assumption that these tests existed in their
current form only for historical reasons.  So here I am, wreaking
general havoc.

> I'm asking as a developer from started with the latter and then switched
> mostly to the former, due to the ease of debugging.
>
> The manual/indent tests also have an automated runner, which uses the
> 'diff' program.

I think that the manual tests fail on at least two accounts:

  1. There is no automated verification of success.

  2. They don't run with "make check".

That said, please feel free to revert any commits you disagree with or
that gets in the way of your work.  I think it goes without saying that
I don't want to make debugging harder for you or anyone else.

But if there are limitations in debugging with ert, perhaps we should
work on improving its capabilities?

Best regards,
Stefan Kangas