emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tab-line-alternate-colors


From: Adam Porter
Subject: Re: [PATCH] tab-line-alternate-colors
Date: Tue, 15 Dec 2020 20:58:35 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Eli Zaretskii <eliz@gnu.org> writes:

>> AFAIK there's no way to inherit only a certain attribute of a face,
>> other than using an anonymous face made at runtime.  If there were, it
>> would be simple to just inherit the mode-line face's background color.
>
> I'm not sure I understand why would want to inherit just the
> background color.  What's wrong with inheriting all the rest?

I would guess that the mode-line face could have other attributes that
we wouldn't want to interfere with the tab-line faces, e.g. size or
family.  The only reason I would want to inherit from mode-line is to
get the background color.

Since this doesn't seem advisable, I've changed the definition of the
tab-line-tab-special face to define the background color explicitly,
using one which is slightly darker than the tab-line face's default.

>> >> +(defface tab-line-tab-special '((t (:slant italic)))
>> >
>> > What will this do on terminals that don''t support italic?
>> 
>> Nothing, I suppose.  :)  I don't often use Emacs in a terminal, so I'm
>> not as familiar with that issue.
>> 
>> I'll be glad to follow whatever guidance you may provide here.  Thanks.
>
> I guess if italics isn't supported, you could use bold or some
> foreground color instead?

Sure.  I've changed the face definition to only use italic on terminals
that support it, and to default to bold otherwise.

These changes will be in the next patch version.  Thanks.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]