emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Additional cleanup around xterm-mouse


From: Stefan Monnier
Subject: Re: Additional cleanup around xterm-mouse
Date: Sun, 27 Dec 2020 12:10:47 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>>> -@defun read-key &optional prompt
>>> +@defun read-key &optional prompt all-fallbacks-disabled
>> FWIW, I would call it "fallbacks-disabled".
> I want to distinguish it from the very similar intentioned but somewhat
> differing behaving parameter to read-key-sequence.

I wouldn't worry 'bout that.
It also occurs to me that it could use a more active form, like 
`disable-fallbacks`.

> This needs to also avoid binding ESC as well, e.g. adding (define-key map
> [?\e] nil).  Cursory testing locally with that as well shows this working
> out well.

Oh, that brings back memories of when I wrote `read-key`.
This is quite delicate indeed.

We're in dire need of tests for those things.

> This assumes that ESC is the only prefix key in input-decode-map.
> Is that an okay assumption to make?

I think so.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]