[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicat
|
From: |
Lars Ingebrigtsen |
|
Subject: |
Re: master b1ac23e 2/2: Allow add-to-ordered-list to use a test predicate |
|
Date: |
Fri, 01 Jan 2021 05:46:59 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Stefan Kangas <stefan@marxist.se> writes:
> It seems like this commit broke some tests:
>
> Ran 6 tests, 2 results as expected, 4 unexpected (2020-12-31
> 10:24:11+0100, 0.402251 sec)
>
> 4 unexpected results:
> FAILED viper-test-undo-1
> FAILED viper-test-undo-2
> FAILED viper-test-undo-3
> FAILED viper-test-undo-4
Right -- my changes here were misguided, because it didn't allow
changing the value of the variable from outside the function.
I've now reverted the change, and there won't be any test-function here,
because the semantics would be too unclear -- the hash table and the
membership function have to use the same predicate, which means that the
first call creates state, and subsequent calls may or may not work.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no