[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Making `kbd` always return a vector (was: [elpa] externals/transient 022
From: |
Stefan Monnier |
Subject: |
Making `kbd` always return a vector (was: [elpa] externals/transient 022f20e: Explicitly require edmacro) |
Date: |
Sat, 23 Oct 2021 10:01:15 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
BTW, the patch below is because `transient` needs to manipulate the
return value of `kbd` and in order to avoid the complexity of having to
deal with "sometimes a string sometimes a vector" it passes the
`need-vector` argument to `edmacro-parse-keys`.
Stefan "who still hasn't encountered a piece of code which
requires `kbd` to return a string rather than a vector"
Jonas Bernoulli [2021-10-23 09:15:56] wrote:
> branch: externals/transient
> commit 022f20e9581b317bffe3457a2422b3a7075761f6
> Author: Jonas Bernoulli <jonas@bernoul.li>
> Commit: Jonas Bernoulli <jonas@bernoul.li>
>
> Explicitly require edmacro
>
> Changes in Emacs' "master" branch make it necessary for
> use to require edmacro explicitly.
>
> Closes #168.
> Closes #166.
> Fixes https://github.com/hlissner/doom-emacs/issues/5670.
> ---
> lisp/transient.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lisp/transient.el b/lisp/transient.el
> index 8752827..c10db31 100644
> --- a/lisp/transient.el
> +++ b/lisp/transient.el
> @@ -54,6 +54,7 @@
>
> (require 'cl-lib)
> (require 'eieio)
> +(require 'edmacro)
> (require 'format-spec)
> (require 'seq)
>
- Making `kbd` always return a vector (was: [elpa] externals/transient 022f20e: Explicitly require edmacro),
Stefan Monnier <=